add vue 3 support #115
Merged
add vue 3 support #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked the package inside a fresh nx workspace (not yarn create-playground) and received some lint errors. |
|
I was able to reproduce the lint errors and warning inside of a playground. The e2e tests should have caught those, but the Vue 3 tests were running against Vue 2 generated projects because of issues with schemas. That's now fixed. |
|
Squash and LGTM!! VUE 3!!!!!!!!!!!!!!!!!!!!! |
BuckyMaler
force-pushed
the
add-vue-3-support
branch
from
26f81a5
to
a44d89e
Compare
ZachJW34
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Vue 3 isn't supported.
Expected Behavior
Vue 3 is supported.
Related Issue(s)
Closes #69
Helpful Vue CLI PRs:
.vuefile shim for Vue 3