Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nx 13 support in dep-graph patchers #249

Merged
merged 1 commit into from
May 16, 2022
Merged

feat: add nx 13 support in dep-graph patchers #249

merged 1 commit into from
May 16, 2022

Conversation

bokub
Copy link
Contributor

@bokub bokub commented May 16, 2022

Current Behavior

Running npm run postinstall throws this error with Nx 13.10:

Failed to patch Nx dep-graph for Vue support. 
Error: ENOENT: no such file or directory, open
'/home/<stuff>/node_modules/@nrwl/workspace/src/core/project-graph/build-dependencies/typescript-import-locator.js'

Expected Behavior

npm run postinstall should patch dep-graph builder function to support Vue files.

Related Issue(s)

No issues, but it's an improved version of #246

N.B

The E2E tests are failing, but the last 2 commits on master failed at the same test so I don't think it's related to my PR.

@ZachJW34
Copy link
Owner

Thanks for the contribution! I'll look into the failing test, probably a new vite version.

@ZachJW34 ZachJW34 merged commit 746e4ea into ZachJW34:master May 16, 2022
@bokub
Copy link
Contributor Author

bokub commented May 17, 2022

Great 🎉

I've opened #253 to fix the failing tests

@konrad-synergy
Copy link

awesome!

@paulhobbel
Copy link

A bit late perhaps but technically the patch is no longer needed right?
https://nx.dev/extending-nx/project-graph-plugins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants