Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Support for the VIM Key Bindings / Mode #8

Closed
StefanoRausch opened this issue Jun 8, 2023 · 5 comments · Fixed by #9
Closed

[FR] Support for the VIM Key Bindings / Mode #8

StefanoRausch opened this issue Jun 8, 2023 · 5 comments · Fixed by #9
Labels
enhancement New feature or request

Comments

@StefanoRausch
Copy link

I use the VIM mode (VIM) on my laptop and iPad with a physical keyboard. It is such a godsend.

Unfortunately, CssE does not support VIM. It is so strange to switch back to the old ways of editing a file / note.

Do you have plans to add this functionality? It would be awesome!

@Zachatoo
Copy link
Owner

Definitely! I'm hoping it'll be as easy as reusing the Codemirror extension Obsidian is using.

Should have time in the next couple of weeks to look into this, I'll be on vacation next week so it'll be at least a week.

@Zachatoo Zachatoo added the enhancement New feature or request label Jun 10, 2023
@StefanoRausch
Copy link
Author

Fantastic and thanks!

Enjoy your vacation. 😎

@StefanoRausch
Copy link
Author

Thank you, Zachatoo!

@Zachatoo
Copy link
Owner

Let me know how this works for you! I only know a few vim bindings since I don't use vim very often, but the bindings I tried appeared to work. Feel free to reopen this issue or create a new issue if there's specific bindings that don't appear to work that would be expected of most/all vim editors and I can give it a look, could easily be accidentally overriding vim keybinds with other keybinds.

@StefanoRausch
Copy link
Author

For an initial release, it works well -- thank you so much!

I have noticed the following:

  • The ESCAPE key exits the insert mode when your work only with one tab containing the CSS snippet. Otherwise, it switches to the left (main target) or the right tab (if the left one does not exist) instead. Returning to the snippet tab results in being back to the normal mode. Can you improve the user experience?

  • The Vimrc Support plugin is not supported. I.e., my personal key bindings are not recognised. It is not a dealbreaker, but it would be fantastic if you could "fine-tune" the user experience here too.

To state it again: A great first implementation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants