Add missing code for full Elmish integration, fixes #601 #602
Conversation
Feliz/UseWithElmish.md
Outdated
| @@ -7,6 +7,8 @@ module App | |||
|
|
|||
| open Feliz | |||
| open Elmish | |||
| open Elmish.HMR | |||
There was a problem hiding this comment.
open Elmish.HMR needs to be the last open instruction in order to be able to shadow any supported API
open Elmish.React
open Elmish.HMRThere was a problem hiding this comment.
Thanks ❤️, I changed the code.
Btw, this is exactly what I meant when I said it would be helpful to include the missing bits. Having to figure out details like this on your own (I didn't know why HMR refused to work) makes life horrible to novices, so providing an example helps a lot.
There was a problem hiding this comment.
True, the things is in this case you should refer to Elmish documentation as it is more complete when using Elmish itself.
But I agree that if Feliz wants to showcase usage inside of Elmish a more complete documentation like you did or link / encouragement to go check Elmish itself is an improvement.
No description provided.