Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/validate transitives #39

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Conversation

MangelMaxime
Copy link
Collaborator

Fix #31 : Validate transitive deps
Fix #32 : Don't report an error if no metadata found

@MangelMaxime
Copy link
Collaborator Author

@Zaid-Ajaj It seems like you added the conflict resolution in #35 only when doing the --resolve or --preview. I suppose we should add it to --validate too?

Copy link
Owner

@Zaid-Ajaj Zaid-Ajaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zaid-Ajaj It seems like you added the conflict resolution in #35 only when doing the --resolve or --preview. I suppose we should add it to --validate too?

Yeah it has be added to --validate and also the project analysis when running femto ./src/App.fsproj but I am getting the feeling that --validate and --preview and the project analysis kind of doing the same thing, don't you think?

Program.fs Show resolved Hide resolved
@MangelMaxime
Copy link
Collaborator Author

I am getting the feeling that --validate and --preview and the project analysis kind of doing the same thing, don't you think?

I asked my self this question in the past and yes they look similar but have small differences.

--preview will fail is not package.json has been found.

While --validate can be used even if no package.json is present.

And --preview show what actions will be applied to the project. It will tell you that it will uninstall that version of the library and install this one.

However, I do think that running femto without arguments is a duplicate of one of the feature we have.

I think --preview and running without args should be the same and output the "nicely formatted" logs.

@Zaid-Ajaj
Copy link
Owner

see #40

@MangelMaxime MangelMaxime merged commit 55496a3 into master Jun 27, 2019
@MangelMaxime
Copy link
Collaborator Author

For me it's ready, with "just" need to wire the conflict resolution in it as mentioned

@Zaid-Ajaj
Copy link
Owner

Awesome! I assigned myself for logging the conflict resolution, I will be able to work on it later tonight

@MangelMaxime MangelMaxime deleted the feature/validate_transitives branch July 24, 2019 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If no Femto metadata found don't log as a warning Transitive dependencies
2 participants