-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/validate transitives #39
Conversation
@Zaid-Ajaj It seems like you added the conflict resolution in #35 only when doing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zaid-Ajaj It seems like you added the conflict resolution in #35 only when doing the --resolve or --preview. I suppose we should add it to --validate too?
Yeah it has be added to --validate
and also the project analysis when running femto ./src/App.fsproj
but I am getting the feeling that --validate
and --preview
and the project analysis kind of doing the same thing, don't you think?
I asked my self this question in the past and yes they look similar but have small differences.
While And However, I do think that running I think |
see #40 |
a1eccfb
to
83ec97c
Compare
For me it's ready, with "just" need to wire the conflict resolution in it as mentioned |
Awesome! I assigned myself for logging the conflict resolution, I will be able to work on it later tonight |
Fix #31 : Validate transitive deps
Fix #32 : Don't report an error if no metadata found