Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectators view empty notes for un-noted players when any note is available #9

Closed
Tempus opened this issue Jan 6, 2018 · 1 comment

Comments

@Tempus
Copy link
Contributor

Tempus commented Jan 6, 2018

Severity: Moderate
Encounter rate: Common

Issue:

On mousing over any note, a spectator sees empty note entries for all players who have not entered a note. ie.

Instantiation:
Zamiel: I am the only one who has made a note
Libster:

Repro:

  1. Begin any game of Hanabi
  2. Have a third party spectate
  3. Have any player create a note on any card
  4. Spectator mouses over note

Expected:

Notes only show the relevant players who have left notes

ie.
Zamiel: I am the only one who has made a note

Issue does not occur while spectating reviews as of yesterday.

@Zamiell
Copy link
Collaborator

Zamiell commented Jan 7, 2018

fixed thanks

@Zamiell Zamiell closed this as completed Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants