Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT/Example - Download all trade data for an account timeline in JSON format plus all PDF files #21

Merged
merged 2 commits into from
Jan 3, 2022

Conversation

blessio
Copy link
Contributor

@blessio blessio commented Jan 3, 2022

Hi,

Happy new year to everyone :-)

There are 2 commits - these are:

  • Improved Exception Interface (potentially a breaking change, although it should not be)
  • Processing of a server-side state "E"(not sure what it means - my understanding is: "Server-side critical error – please re-initiate the connection")

The second commit is a script that uses these changes to download in JSON format the complete timeline and the details for it plus ALL the PDF documents in a dedicated folder.

Best Regards,
Blessio

@Zarathustra2
Copy link
Owner

Wow, nice work. That looks awesome, pretty big changes!!

Let me know when u are comfortable and I will take a second look over it and then merge it!

@blessio
Copy link
Contributor Author

blessio commented Jan 3, 2022

Please have a second look and use all the time you need - the change in the API is somewhat risky... probably we can rename it public apiv2.0

@blessio blessio marked this pull request as ready for review January 3, 2022 00:35
@Zarathustra2
Copy link
Owner

I am fine with the changes, like the new custom exceptions. As for server state E, I am also unsure but ur explanation makes sense! Can be merged IMO

@Zarathustra2
Copy link
Owner

@blessio I can merge now if you'd like to

@blessio
Copy link
Contributor Author

blessio commented Jan 3, 2022

@Zarathustra2
I am fine with the merge- thanks :)

@Zarathustra2 Zarathustra2 merged commit 92beacf into Zarathustra2:master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants