Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix evaluated values #18

Closed
wants to merge 3 commits into from
Closed

Fix evaluated values #18

wants to merge 3 commits into from

Commits on Apr 7, 2014

  1. style(interpreter): break some overlong lines

    @davidlinse
    davidlinse committed Apr 7, 2014
    Copy the full SHA
    c82d7c4 View commit details
    Browse the repository at this point in the history

  2. refactor(interpreter): move verify-step success to local variable

    @davidlinse
    davidlinse committed Apr 7, 2014
    Copy the full SHA
    9270197 View commit details
    Browse the repository at this point in the history

  3. fix(interpreter): compare values from 'verifyEval' 

    This is an attempt to fix an issue described in SeleniumBuilder/se-builder#163
which allows comparison of evaluated values.

Example:
{
  "type": "verifyEval",
  "script": "return true;",
  "value": "true"
}

Before: Error: "true" does not match "true"
After: true
    @davidlinse
    davidlinse committed Apr 7, 2014
    Copy the full SHA
    b48c9db View commit details
    Browse the repository at this point in the history