Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LICENSE file #51

Merged
merged 1 commit into from
Oct 10, 2021
Merged

Add LICENSE file #51

merged 1 commit into from
Oct 10, 2021

Conversation

jsdanielh
Copy link
Contributor

Add LICENSE file to state MIT as the license of this repository.
This closes #33.

@oxarbitrage
Copy link

I think MIT should be ok here as this project was made from scratch however i am not totally sure, we better call @dconnolly or @mpguerra to figure out this.

Copy link
Collaborator

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add Apache-2.0 LICENSE file?

You can see an example of how we do licenses in the Zebra repository:

And here's the current license for this repository, as a SPDX identifier:

license = "MIT OR Apache-2.0"

@jsdanielh
Copy link
Contributor Author

Can you also add Apache-2.0 LICENSE file?

You can see an example of how we do licenses in the Zebra repository:

* https://github.com/ZcashFoundation/zebra

And here's the current license for this repository, as a SPDX identifier:

license = "MIT OR Apache-2.0"

Done. Also added a small description of the license in the README.md file.

Add LICENSE files to state MIT or Apache 2.0 as the licenses of this
repository.
This closes ZcashFoundation#33.
Copy link
Collaborator

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good!

I'll merge it now, so it gets in the upcoming release.
(cc @dconnolly)

@teor2345 teor2345 merged commit 68710ed into ZcashFoundation:main Oct 10, 2021
@jsdanielh jsdanielh deleted the license branch October 11, 2021 02:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing license file
3 participants