add no-std support #621
Merged
add no-std support #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I think this is a breaking change since it removes the Error trait impl. I'll change it so that only happens in no-std mode. |
|
In case it's useful I have a |
This is great, but we'd prefer if that was incorporated upstream. Did you consider opening a PR there? |
natalieesk
approved these changes
Jun 20, 2024
natalieesk
pushed a commit
that referenced
this pull request
Jun 27, 2024
* add no-std support * add no-std support to ciphersuite crates * fix ci * update changelog, use 'dep:' where appropriate * additional fixes * fix clippy issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't add it to frost-ed448 because Ed448-Goldilocks doesn't support it. I'll eventually create a PR there and we can enable it in frost-ed448 later.
Closes #535
This is a draft just because it's a breaking change and we need to decide when to merge it. Otherwise it's ready.