Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce maximum of 256 participants with u64 indexes #111

Open
oxarbitrage opened this issue May 26, 2021 · 3 comments
Open

Enforce maximum of 256 participants with u64 indexes #111

oxarbitrage opened this issue May 26, 2021 · 3 comments
Assignees
@dconnolly @chelseakomlo
Labels
frost

Comments

@oxarbitrage
Copy link
Contributor

oxarbitrage commented May 26, 2021 •
edited

In #110 we changed all indexes to u64 and by this we lose some of the enforcement we had by using an u8.

We should resolve this in the context of #108
@upbqdn
Copy link
Member

upbqdn commented May 27, 2021

#108 (comment)

@oxarbitrage
Copy link
Contributor Author

It looks to me the limit is still being imposed in #110 but there should be something i am not seeing. There is some discussion about it at #110 (comment)

@upbqdn
Copy link
Member

upbqdn commented Jun 1, 2021

I'm also not sure about this because even though the identifiers are longer, the dealer is not able to take in a number bigger than 255.

@ftm1000 ftm1000 added the frost label Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dconnolly dconnolly

@chelseakomlo chelseakomlo

Labels
frost
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dconnolly @chelseakomlo @upbqdn @oxarbitrage @ftm1000