Change the type of the identifiers from u8 to u64 #110
Conversation
src/frost.rs
Outdated
| /// The number of nonces is limited to 255. This limit can be increased if it | ||
| /// turns out to be too conservative. |
There was a problem hiding this comment.
This is no longer enforced by the type (u8) so we should either change this doc comment or enforce it in the code
There was a problem hiding this comment.
There was a problem hiding this comment.
What was once enforced by the type system is not anymore in this PR.
There was a problem hiding this comment.
Sorry, it is still not clear to me. Can you make a suggestion on how the comment should be ? I am thinking on just removing it.
There was a problem hiding this comment.
Let's:
- create an issue to 'enforce maximum of 256 participants with u64 indexes'
- mention that as a TODO in this comment
Then I think that'll be fine to get this change merged, that ticket should also be resolved in Marek's PR
There was a problem hiding this comment.
Sounds good, i created the ticket and added a suggestion here to change the comment.
There was a problem hiding this comment.
Note that the number of these nonces is not really related to the number of participants. These nonces are generated for each participant during the preprocessing stage. Our "message protocol" currently supports only one pair of nonces per signature so that the nonces (and corresponding commitments) are not cached and signing is always two-round.
(Here's the rationale for omitting cached nonces for now: #85 (comment))
Just do the type change from #108