Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change participant identifiers in Trusted Dealer variant #108

Closed
wants to merge 6 commits into from
Closed

Change participant identifiers in Trusted Dealer variant #108

wants to merge 6 commits into from

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented May 24, 2021 •
edited by mpguerra
Loading

At the moment, the identifiers are changed from u8 to u64.

This will close issue #77 once the identifiers are generated by the hash function.

This change is Reviewable

@upbqdn upbqdn added the frost label May 24, 2021
@upbqdn upbqdn self-assigned this May 24, 2021
@upbqdn upbqdn linked an issue May 24, 2021 that may be closed by this pull request
Change participant identifiers in Trusted Dealer variant #77
Open
@upbqdn upbqdn removed a link to an issue May 24, 2021
Change participant identifiers in Trusted Dealer variant #77
Open
@upbqdn upbqdn marked this pull request as draft May 24, 2021 15:22
@oxarbitrage oxarbitrage mentioned this pull request May 24, 2021
Closed
oxarbitrage
oxarbitrage previously approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@upbqdn upbqdn marked this pull request as ready for review May 25, 2021 11:35
@upbqdn
Copy link
Member Author

upbqdn commented May 25, 2021

The identifiers are now generated as described in issue #77.

@upbqdn
Copy link
Member Author

upbqdn commented May 25, 2021 •
edited
Loading

Note: The dealer still takes in a u8 for the number of participants, so the limit is still imposed.

redjubjub/src/frost.rs

Line 173 in 709b22e

num_signers: u8,

@upbqdn upbqdn linked an issue May 25, 2021 that may be closed by this pull request
Change participant identifiers in Trusted Dealer variant #77
Open
dconnolly
dconnolly reviewed May 26, 2021
View reviewed changes
src/frost.rs Outdated Show resolved Hide resolved
dconnolly
dconnolly reviewed May 26, 2021
View reviewed changes
src/frost.rs Outdated Show resolved Hide resolved
This was referenced May 26, 2021
Merged
Open
dconnolly
dconnolly reviewed May 31, 2021
View reviewed changes
src/frost.rs Outdated Show resolved Hide resolved
dconnolly
dconnolly reviewed May 31, 2021
View reviewed changes
src/frost.rs Outdated Show resolved Hide resolved
@upbqdn upbqdn requested a review from dconnolly June 2, 2021 17:24
@oxarbitrage oxarbitrage mentioned this pull request Jun 3, 2021
Open
@upbqdn
Fix integration tests
46f8e2c 
Some test were failing because they were not using the new identifiers, but were
trying to identify the participants by simple indices such as 1, 2, 3.
@upbqdn
Improve code cosmetics
1ff55b8
@upbqdn
Copy link
Member Author

upbqdn commented Aug 1, 2021

Some test were failing because they were not using the new identifiers, but were trying to identify the participants by simple indices such as 1, 2, 3. They are fixed now.

@conradoplg
Copy link
Contributor

Closing this since it's outdated, FROST code is now in https://github.com/ZcashFoundation/frost/

@conradoplg conradoplg closed this Apr 21, 2023
@upbqdn upbqdn deleted the new-identifiers branch April 21, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage Awaiting requested review from oxarbitrage

@chelseakomlo chelseakomlo Awaiting requested review from chelseakomlo

@dconnolly dconnolly Awaiting requested review from dconnolly

Assignees

@upbqdn upbqdn

Labels
frost
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change participant identifiers in Trusted Dealer variant
5 participants
@upbqdn @conradoplg @dconnolly @chelseakomlo @oxarbitrage