fix(lint): fix a new lint for the last clippy version #1186
cd-deploy-nodes-gcp.patch-external.yml
on: pull_request
Build CD Docker / Build images
0s
Test CD default Docker config file / Test default-conf in Docker
0s
Test CD testnet Docker config file / Test default-conf in Docker
0s
Test CD custom Docker config file / Test custom-conf in Docker
0s
Annotations
2 errors
usage of a legacy numeric constant:
zebra-chain/src/work/difficulty/arbitrary.rs#L52
error: usage of a legacy numeric constant
--> zebra-chain/src/work/difficulty/arbitrary.rs:52:13
|
52 | (1..std::u128::MAX).prop_map(Work).boxed()
| ^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
52 | (1..u128::MAX).prop_map(Work).boxed()
| ~~~~~~~~~
|
usage of a legacy numeric method:
zebra-chain/src/sapling/keys.rs#L94
error: usage of a legacy numeric method
--> zebra-chain/src/sapling/keys.rs:94:31
|
94 | assert!(tag[i] != u8::max_value());
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
= note: `-D clippy::legacy-numeric-constants` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::legacy_numeric_constants)]`
help: use the associated constant instead
|
94 | assert!(tag[i] != u8::MAX);
| ~~~
|