Skip to content

fix(lint): fix a new lint for the last clippy version #1186

fix(lint): fix a new lint for the last clippy version

fix(lint): fix a new lint for the last clippy version #1186

GitHub Actions / Clippy (stable) Results failed Jun 14, 2024 in 0s

Clippy (stable) Results

2 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 2
Warning 0
Note 0
Help 0

Versions

  • rustc 1.79.0 (129f3b996 2024-06-10)
  • cargo 1.79.0 (ffa9cf99a 2024-06-03)
  • clippy 0.1.79 (129f3b9 2024-06-10)

Annotations

Check failure on line 52 in zebra-chain/src/work/difficulty/arbitrary.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (stable) Results

usage of a legacy numeric constant

error: usage of a legacy numeric constant
  --> zebra-chain/src/work/difficulty/arbitrary.rs:52:13
   |
52 |         (1..std::u128::MAX).prop_map(Work).boxed()
   |             ^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
   |
52 |         (1..u128::MAX).prop_map(Work).boxed()
   |             ~~~~~~~~~

Check failure on line 94 in zebra-chain/src/sapling/keys.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (stable) Results

usage of a legacy numeric method

error: usage of a legacy numeric method
  --> zebra-chain/src/sapling/keys.rs:94:31
   |
94 |         assert!(tag[i] != u8::max_value());
   |                               ^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
   = note: `-D clippy::legacy-numeric-constants` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::legacy_numeric_constants)]`
help: use the associated constant instead
   |
94 |         assert!(tag[i] != u8::MAX);
   |                               ~~~