Apply suggestions from code review

ZcashFoundation · May 1, 2024 · 8128a07 · 8128a07
1 parent 855ad12
commit 8128a07
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/zebra-consensus/src/block/subsidy/general.rs b/zebra-consensus/src/block/subsidy/general.rs
@@ -87,7 +87,7 @@ pub fn block_subsidy(height: Height, network: &Network) -> Result<Amount<NonNega
 
     // TODO: Add this as a field on `testnet::Parameters` instead of checking `disable_pow()`, this is 0 for Regtest in zcashd,
     //       see <https://github.com/zcash/zcash/blob/master/src/chainparams.cpp#L640>
-    if height < SLOW_START_SHIFT && !network.disable_pow() {
+    if height < SLOW_START_INTERVAL && !network.disable_pow() {
         unreachable!(
             "unsupported block height {height:?}: callers should handle blocks below {SLOW_START_INTERVAL:?}",
         )

diff --git a/zebra-state/src/service/check.rs b/zebra-state/src/service/check.rs
@@ -96,7 +96,7 @@ where
     // checkpoint verified. The state queues and block write task make sure that blocks are
     // committed in strict height order. But this function is only called on semantically
     // verified blocks, so there will be at least 1 million blocks in the state when it is
-    // called. So this error should never happen.
+    // called. So this error should never happen on Mainnet or the default Testnet.
     #[cfg(not(test))]
     if relevant_chain.is_empty() {
         return Err(ValidateContextError::NotReadyToBeCommitted);