Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security: Track the number of open inbound and outbound connections separately #2904

Closed
Tracked by #2867
teor2345 opened this issue Oct 19, 2021 · 0 comments · Fixed by #2912
Closed
Tracked by #2867

Security: Track the number of open inbound and outbound connections separately #2904

teor2345 opened this issue Oct 19, 2021 · 0 comments · Fixed by #2912
Labels
A-network Area: Network protocol updates or fixes C-security Category: Security issues I-remote-node-overload Zebra can overload other nodes on the network
Milestone
2021 Sprint 21

Comments

@teor2345
Copy link
Collaborator

Motivation

To limit the number of inbound and outbound connections in Zebra, we need to track them separately.

Suggested Design

Split the changes from #2903 into inbound and outbound.

See #1850, #1851, and #2902 for details of which functions make inbound and outbound connections.

Edge Cases

How can we make sure the inbound and outbound signals don't block each other?

How can we make sure we don't get the inbound and outbound signals mixed up?
@teor2345 teor2345 added S-blocked Status: Blocked on other tasks S-needs-triage Status: A bug report needs triage P-High C-security Category: Security issues I-remote-node-overload Zebra can overload other nodes on the network A-network Area: Network protocol updates or fixes labels Oct 19, 2021
@teor2345 teor2345 added this to the 2021 Sprint 21 milestone Oct 19, 2021
This was referenced Oct 19, 2021
Closed
Closed
Merged
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Oct 29, 2021
@mpguerra mpguerra removed the S-blocked Status: Blocked on other tasks label Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-network Area: Network protocol updates or fixes C-security Category: Security issues I-remote-node-overload Zebra can overload other nodes on the network
Projects
None yet
Milestone
2021 Sprint 21
Development

Successfully merging a pull request may close this issue.

Track the number of active inbound and outbound peer connections ZcashFoundation/zebra
2 participants
@mpguerra @teor2345