Track the number of active inbound and outbound peer connections #2912
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To limit the number of connections in Zebra, we need to be able to track how many open connections there are.
Solution
ActiveConnectionCounter
typeConnectionTracker
type that increases the count when it's created, and decreases the count when it's droppedConnection
s close or fail, by adding aConnectionTracker
to eachConnection
Closes #2903.
Closes #2904.
This PR will get tested as part of tickets #1850 and #2902, when we actually enforce connection limits.
Review
@oxarbitrage and @dconnolly wanted to work on the security tickets that depend on this PR.
So they probably want to review it.
This PR is on the critical path for the Zebra beta, so it's urgent.
Reviewer Checklist
Security edge-cases:
Follow Up Work