Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update block production algorithm once ZIP-317 updates #5752

Closed
teor2345 opened this issue Nov 30, 2022 · 1 comment · Fixed by #5776
Closed

Update block production algorithm once ZIP-317 updates #5752

teor2345 opened this issue Nov 30, 2022 · 1 comment · Fixed by #5776
Assignees
@teor2345
Labels
A-rpc Area: Remote Procedure Call interfaces C-enhancement Category: This is an improvement C-security Category: Security issues I-heavy Problems with excessive memory, disk, or CPU usage

Comments

@teor2345
Copy link
Contributor

teor2345 commented Nov 30, 2022 •
edited
Loading

Motivation

We're expecting a minor update to the ZIP-317 block production algorithm.

Specifications

https://zips.z.cash/zip-0317

With the changes from the PR:
zcash/zips#650

Designs

  1. Replace the dynamic size limit with a fixed action limit. This makes the design simpler.

    • Don't make the limit configurable for now, we'll see if we need to do that later.

  2. Update comments to link to ZIP-313:

  3. Replace "transparent P2SH single signature address" with "transparent P2SH address", the single signature part is wrong
@teor2345 teor2345 added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage P-Medium ⚡ C-security Category: Security issues I-heavy Problems with excessive memory, disk, or CPU usage A-rpc Area: Remote Procedure Call interfaces labels Nov 30, 2022
@teor2345 teor2345 mentioned this issue Nov 30, 2022
Merged
5 tasks
@teor2345 teor2345 self-assigned this Dec 1, 2022
@teor2345 teor2345 mentioned this issue Dec 2, 2022
Merged
5 tasks
@mpguerra
Copy link
Contributor

mpguerra commented Dec 2, 2022

@teor2345 can you please add an estimate to this issue?

@mergify mergify bot closed this as completed in #5776 Dec 8, 2022
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teor2345 teor2345

Labels
A-rpc Area: Remote Procedure Call interfaces C-enhancement Category: This is an improvement C-security Category: Security issues I-heavy Problems with excessive memory, disk, or CPU usage
Projects
Zebra
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change(rpc): Update ZIP-317 transaction selection algorithm ZcashFoundation/zebra
2 participants
@mpguerra @teor2345