Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZIP 317: change block template construction to use "algorithm 4" #650

Merged
merged 7 commits into from
Dec 7, 2022
Merged

ZIP 317: change block template construction to use "algorithm 4" #650

merged 7 commits into from
Dec 7, 2022

Conversation

daira
Copy link
Collaborator

@daira daira commented Dec 1, 2022

No description provided.

@daira daira requested review from nuttycom, dconnolly, str4d and a team December 1, 2022 01:48
@daira
ZIP 317: change block template construction algorithm.
afd297c 
Also update the acknowledgements.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@daira
CSS vertical spacing tweaks.
2a6e5ae 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@daira
ZIP 317: ensure that the case in block template construction where
fc56098 
all remaining transactions have zero weight ratio is well-defined.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@daira daira mentioned this pull request Dec 1, 2022
Merged
5 tasks
madars
madars reviewed Dec 1, 2022
View reviewed changes
zip-0317.html Show resolved Hide resolved
madars
madars reviewed Dec 1, 2022
View reviewed changes
zip-0317.rst Outdated Show resolved Hide resolved
@daira
Explain the use of max(1, tx.fee), and write weight_ratio as math.
a9ef048 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@teor2345 teor2345 mentioned this pull request Dec 1, 2022
Closed
teor2345
teor2345 reviewed Dec 4, 2022
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is some feedback, mainly from our experience implementing ZIP-317 with Zebra.

zip-0317.rst Outdated Show resolved Hide resolved
zip-0317.rst Outdated Show resolved Hide resolved
zip-0317.rst Show resolved Hide resolved
@daira
ZIP 317: add Daira Hopwood as an Owner.
3551fdb 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@daira
ZIP 317: allow nodes to drop transactions with more than
957cc57 
block_unpaid_action_limit unpaid actions.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@daira
ZIP 317: address Teor's comments.
0d9a960 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@daira daira merged commit 4d60ae1 into zcash:main Dec 7, 2022
@daira daira deleted the zip-317-algorithm-4 branch December 7, 2022 21:30
@str4d str4d mentioned this pull request Feb 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madars madars madars left review comments

@teor2345 teor2345 teor2345 left review comments

@nuttycom nuttycom Awaiting requested review from nuttycom

@dconnolly dconnolly Awaiting requested review from dconnolly

@str4d str4d Awaiting requested review from str4d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daira @madars @teor2345