change(rpc): Select getblocktemplate RPC transactions according to ZIP-317 #5724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
A-dependencies
teor2345
commented
Nov 25, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5724 +/- ##
==========================================
+ Coverage 78.67% 79.09% +0.41%
==========================================
Files 306 306
Lines 38552 39768 +1216
==========================================
+ Hits 30331 31454 +1123
- Misses 8221 8314 +93 |
This will be used for block production and relaying
teor2345
force-pushed
the
zip-317-getblocktemplate
branch
from
3a83759
to
b1c03e5
Compare
teor2345
requested review from
oxarbitrage and
dconnolly
and removed request for
a team
|
The code in this PR will have further changes after a ZIP update. I suggest we review and merge it based on the current ZIP-317, and then do the update in a separate PR based on ticket #5752. That will make reviewing the update easier, because the diff will be smaller. |
|
(Oops, pressed the wrong button.) |
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
Note that the algorithm has changed, as discussed in ZIP sync. PR here: zcash/zips#650 |
|
Please don't worry about restarting the tests in this PR, or merging in main, I'm going to update the code tomorrow anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to select transactions for block production according to ZIP-317.
Close #5473.
Depends-On: #5761
Specifications
https://zips.z.cash/zip-0317#recommended-algorithm-for-block-template-construction
Designs
Follow the recommended algorithm in the specification.
Use
f32for efficient calculations and weight storage.Use a minimum fee weight of
1.0 / 20.0to simplify the implementation. (This is not in the spec, but changes are allowed because it is not consensus-critical. If the ZIP editors disagree with this, I'll open another PR to fix it.)Use the same random weight APIs that we use in mempool transaction eviction.
Some parts of this PR are outside the
getblocktemplate-rpcsfeature, because we will probably use them in ticket #5336.Solution
Related Refactors:
This PR has some testing from the existing test vectors and snapshot tests.
The rest of its tests will be implemented as part of ticket #5652.
Review
We should probably get two reviews on this.
Reviewer Checklist