Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the value pools design we created several methods that receive a
Hashmap
withUtxo
s, just as:However, the
Utxo
is azebra-state
type.Note:
zebra-chain
do not depend onzebra-state
Designs
Value Pools Design
Solution
Move the state
Utxo
type intozebra-chain::transparent
so we can have it available in method signatures. This is a pretty noisy change so i separated it from the value pool implementation but it is part of #1895Review
I am not sure if we have a better alternative but i think this is needed. Anyone can review the code.
Reviewer Checklist
Follow Up Work
Continue the implementation of value pools in #1895