fix(deps): Update yanked versions of cpufeatures (orchard/aes), ed25519 (tor), and quick-xml (flamegraph) #5308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some of Zebra's transitive dependencies have been yanked (unpublished on crates.io).
The latest versions fix a miscompile that causes crashes in cryptographic code, and other bugs.
This fixes compilation warnings like:
https://github.com/ZcashFoundation/zebra/actions/runs/3150408776/jobs/5123159992#step:4:18
https://github.com/ZcashFoundation/zebra/actions/runs/3170245187
Solution
Use
cargo update -p <crate-name>
to update each of these dependencies to the latest version inCargo.lock
.(We don't depend on them directly, so we can't update
Cargo.toml
to fix them.)Review
This is a high priority because it might be a cause of #5091.
(These dependencies are not used by the download code, but they are in the same crate. So it's unlikely but possible.)
Reviewer Checklist