Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(doc): Add draft audit process, and update some support docs #5433

Merged
merged 5 commits into from
Oct 21, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Oct 19, 2022

Motivation

Let's document the audit decisions we've taken so far, we can update them later if they change.

This PR also makes some minor support documentation fixes.

Close #5431.

Solution

The audit doc is based on meetings, slack conversations, ticket #5214, and PR #5395.

The release process changes fix an incorrect render on main, and make the document consistent with our other markdown docs.

The download workaround addresses a bug report in the #zebra discord channel.

The build doc changes replace an outdated build process with a link to the latest documentation in the README.

Review

Anyone can review this PR, but @gustavovalverde opened the audit ticket.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

Follow Up Work

Edit this document if the audit process changes significantly.

@teor2345 teor2345 added A-docs Area: Documentation A-devops Area: Pipelines, CI/CD and Dockerfiles P-Medium ⚡ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Oct 19, 2022
@teor2345 teor2345 requested a review from a team as a code owner October 19, 2022 20:44
@teor2345 teor2345 self-assigned this Oct 19, 2022
@teor2345 teor2345 requested review from upbqdn and removed request for a team October 19, 2022 20:44
@github-actions github-actions bot added the C-feature Category: New features label Oct 19, 2022
Copy link
Contributor

@mpguerra mpguerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for writing this!

book/src/dev/release-process.md Show resolved Hide resolved
README.md Show resolved Hide resolved
book/src/dev/release-process.md Show resolved Hide resolved
mergify bot added a commit that referenced this pull request Oct 21, 2022
@mergify mergify bot merged commit 17c0bac into main Oct 21, 2022
@mergify mergify bot deleted the support-audit-docs branch October 21, 2022 01:20
oxarbitrage added a commit that referenced this pull request Oct 31, 2022
the version in the book install.md was removed in #5433
mergify bot pushed a commit that referenced this pull request Oct 31, 2022
…#5514)

* fix name suggestion

* remove not needed task

the version in the book install.md was removed in #5433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-docs Area: Documentation C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Explain the process to be taken when a code audit is to take place
3 participants