Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump zcash_proofs from 0.8.0 to 0.9.0 and zcash_primitives from 0.8.1 to 0.9.0 #5631

Merged
merged 6 commits into from Nov 18, 2022

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Nov 15, 2022

Motivation

We want to update these at the same time.

Replaces #5627 and #5628

Review

Anyone can review

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

bump zcash_primitives from 0.8.0 to 0.9.0
@arya2 arya2 added A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code P-Medium ⚡ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Nov 15, 2022
@arya2 arya2 self-assigned this Nov 15, 2022
@arya2 arya2 requested a review from a team as a code owner November 15, 2022 00:59
@arya2 arya2 requested review from dconnolly and removed request for a team November 15, 2022 00:59
dconnolly
dconnolly previously approved these changes Nov 15, 2022
Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #5631 (1c7dadf) into main (a2f2a14) will increase coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5631      +/-   ##
==========================================
+ Coverage   78.72%   78.79%   +0.06%     
==========================================
  Files         305      305              
  Lines       38503    38503              
==========================================
+ Hits        30313    30337      +24     
+ Misses       8190     8166      -24     

@gustavovalverde
Copy link
Member

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Nov 16, 2022

update

✅ Branch has been successfully updated

@arya2
Copy link
Contributor Author

arya2 commented Nov 16, 2022

ssh failure:

gcloud compute ssh fully-synced-rpc-5631-merge-7cd38d3 --project=zealous-zebra --zone=us-central1-a --troubleshoot

Or, to investigate an IAP tunneling issue:

gcloud compute ssh fully-synced-rpc-5631-merge-7cd38d3 --project=zealous-zebra --zone=us-central1-a --troubleshoot --tunnel-through-iap

ERROR: (gcloud.compute.ssh) [/usr/bin/ssh] exited with return code [255].
Error: Process completed with exit code 255.

https://github.com/ZcashFoundation/zebra/actions/runs/3481795921/jobs/5824112862#step:9:116

@arya2
Copy link
Contributor Author

arya2 commented Nov 16, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Nov 16, 2022

update

✅ Branch has been successfully updated

@arya2
Copy link
Contributor Author

arya2 commented Nov 16, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Nov 16, 2022

update

✅ Branch has been successfully updated

Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approvals will continue until ssh improves 🫠

mergify bot added a commit that referenced this pull request Nov 18, 2022
@mpguerra
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Nov 18, 2022

update

✅ Branch has been successfully updated

@arya2
Copy link
Contributor Author

arya2 commented Nov 18, 2022

get_block_template test failed with:

Message: negating a NonNegative amount always results in a valid NegativeOrZero: Constraint { value: 43740, range: -2100000000000000..=0 }
Location: zebra-rpc/src/methods/get_block_template_rpcs/types/transaction.rs:105

https://github.com/ZcashFoundation/zebra/actions/runs/3498079512/jobs/5859110894#step:6:264

mergify bot added a commit that referenced this pull request Nov 18, 2022
@mergify mergify bot merged commit b722e22 into main Nov 18, 2022
@mergify mergify bot deleted the bump-zcash-proofs-and-primitives branch November 18, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants