Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testnet): Increase legacy chain limit to 100,000 #6053

Merged
merged 1 commit into from Jan 31, 2023
Merged

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Jan 31, 2023

Motivation

I just restarted my testnet instance, and it has been 10,000 blocks without a v5 transaction. So we need to increase the limit again.

Ticket #5912 will make this check partly redundant, because it will verify all the checkpoints to make sure we are on the correct chain.

Solution

Just increase the constant for the number of blocks.

Review

This is a low priority testnet fix.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-bug Category: This is a bug A-consensus Area: Consensus rule updates P-Low ❄️ I-panic Zebra panics with an internal error message A-state Area: State / database changes labels Jan 31, 2023
@teor2345 teor2345 self-assigned this Jan 31, 2023
@teor2345 teor2345 requested a review from a team as a code owner January 31, 2023 00:31
@teor2345 teor2345 requested review from upbqdn and removed request for a team January 31, 2023 00:31
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #6053 (9357a94) into main (e20cf95) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6053      +/-   ##
==========================================
+ Coverage   78.25%   78.27%   +0.01%     
==========================================
  Files         312      312              
  Lines       39418    39418              
==========================================
+ Hits        30846    30853       +7     
+ Misses       8572     8565       -7     

mergify bot added a commit that referenced this pull request Jan 31, 2023
@mergify mergify bot merged commit f3eaa04 into main Jan 31, 2023
@mergify mergify bot deleted the legacy-chain-100k branch January 31, 2023 20:37
teor2345 added a commit that referenced this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates A-state Area: State / database changes C-bug Category: This is a bug I-panic Zebra panics with an internal error message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants