-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mempool): add ZIP-317 rules to mempool #6556
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6556 +/- ##
==========================================
+ Coverage 77.78% 78.10% +0.32%
==========================================
Files 307 309 +2
Lines 40273 40621 +348
==========================================
+ Hits 31325 31727 +402
+ Misses 8948 8894 -54 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for doing this!
I hope it wasn't too complicated, it seems like updating the tests was a bit of work.
I just want to check where these rules are coming from, to make sure we got them all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these changes, I am going to go and see what I can do with the fee rate code using the Rust compiler.
… use usize (#6585) * Refactor the minimum fee rate calculation to use usize * Check for overflow if constants change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, looks great!
Motivation
We want to add ZIP-317 relay rules to the mempool verifier, so Zebra can drop transactions before they get into the mempool storage.
Close #5336
Specifications
Solution
This pull request is checking 2 rules currently:
If there are more rules they need to be added to
zebra_chain::transactions::unmined::mempool_checks
function.Review
Reviewer Checklist
Follow Up Work