Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testnet): listen_addr default deserialization #6575

Merged
merged 1 commit into from Apr 27, 2023
Merged

fix(testnet): listen_addr default deserialization #6575

merged 1 commit into from Apr 27, 2023

Conversation

oxarbitrage
Copy link
Contributor

Motivation

Resolve a small bug report. Fixes #6386

Solution

  • Changed deserialization to 0.0.0.0 as suggested.
  • Tested manually, bug is gone.
  • All tests pass locally.
  • Need to see if the CI pass.

Review

Anyone can review.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

Follow Up Work

@oxarbitrage oxarbitrage requested a review from a team as a code owner April 26, 2023 19:46
@oxarbitrage oxarbitrage requested review from upbqdn and removed request for a team April 26, 2023 19:46
@github-actions github-actions bot added C-bug Category: This is a bug C-feature Category: New features labels Apr 26, 2023
@oxarbitrage oxarbitrage self-assigned this Apr 26, 2023
@teor2345 teor2345 added I-usability Zebra is hard to understand or use and removed C-feature Category: New features labels Apr 26, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #6575 (1708264) into main (a1b3246) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6575      +/-   ##
==========================================
- Coverage   77.76%   77.74%   -0.03%     
==========================================
  Files         307      307              
  Lines       40287    40287              
==========================================
- Hits        31331    31322       -9     
- Misses       8956     8965       +9     

mergify bot added a commit that referenced this pull request Apr 26, 2023
@mergify mergify bot merged commit 0ffd31e into main Apr 27, 2023
226 checks passed
@mergify mergify bot deleted the issue6386 branch April 27, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug I-usability Zebra is hard to understand or use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use default testnet port on testnet when Zcash listener address is not supplied
3 participants