Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(Docker): Enable miners to set their address for mining rewards. #7178

Merged
merged 2 commits into from Jul 10, 2023
Merged

add(Docker): Enable miners to set their address for mining rewards. #7178

merged 2 commits into from Jul 10, 2023

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Jul 9, 2023 •
edited

Motivation

Close #6752.

Solution

This PR became trivial, given all the preceding updates we did.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

Follow Up Work

#7179

@upbqdn upbqdn added A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement P-Medium ⚡ labels Jul 9, 2023
@upbqdn upbqdn requested a review from a team as a code owner July 9, 2023 17:54
@upbqdn upbqdn self-assigned this Jul 9, 2023
@upbqdn upbqdn requested review from gustavovalverde and removed request for a team July 9, 2023 17:54
@github-actions github-actions bot added the C-feature Category: New features label Jul 9, 2023
@teor2345 teor2345 mentioned this pull request Jul 9, 2023
Merged
6 tasks
Base automatically changed from enable-rpc-port to main July 10, 2023 06:07
gustavovalverde
gustavovalverde reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mergify bot added a commit that referenced this pull request Jul 10, 2023
@mergify
Merge of #7178
c39bbf6
@mergify mergify bot mentioned this pull request Jul 10, 2023
Closed
@mergify mergify bot merged commit 32dd618 into main Jul 10, 2023
277 checks passed
@mergify mergify bot deleted the pass-mining-config branch July 10, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

@gustavovalverde gustavovalverde gustavovalverde approved these changes

Assignees

@upbqdn upbqdn

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement C-feature Category: New features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass mining config to the mining Docker container at runtime
3 participants
@upbqdn @teor2345 @gustavovalverde