Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp(workflows): use larger runners on time consuming jobs #7626

Merged
merged 1 commit into from
Sep 25, 2023
Merged

imp(workflows): use larger runners on time consuming jobs #7626

merged 1 commit into from
Sep 25, 2023

Conversation

gustavovalverde
Copy link
Member

Motivation

Some jobs take too much time to run, having to wait too much time between commits to confirm everything is working as expected, and making merge queues slower

Fixes: #7180
Closes: #6457
Fixes: #7625

Specifications

https://docs.github.com/en/actions/using-github-hosted-runners/about-larger-runners/about-larger-runners

Solution

  • Add different larger runners to handle these time consuming jobs

Review

  • Confirm the time has been reduced to acceptable limits

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

Follow Up Work

None

@gustavovalverde gustavovalverde added A-devops Area: Pipelines, CI/CD and Dockerfiles P-High 🔥 I-slow Problems with performance or responsiveness C-feature Category: New features labels Sep 25, 2023
@gustavovalverde gustavovalverde self-assigned this Sep 25, 2023
@gustavovalverde gustavovalverde marked this pull request as ready for review September 25, 2023 22:24
@gustavovalverde gustavovalverde requested a review from a team as a code owner September 25, 2023 22:24
@gustavovalverde gustavovalverde requested review from arya2 and removed request for a team September 25, 2023 22:24
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Sep 25, 2023
teor2345
teor2345 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@teor2345 teor2345 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this because it's a tiny change that will significantly speed up CI for the other 8 open PRs.

Someone else can review it if they like!

@teor2345
Copy link
Collaborator

Just copying these post-merge steps from ticket #7180:

@mergify mergify bot merged commit 0309afc into main Sep 25, 2023
135 checks passed
@mergify mergify bot deleted the imp-test-times branch September 25, 2023 23:33
@upbqdn upbqdn mentioned this pull request Oct 13, 2023
Merged
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

@arya2 arya2 Awaiting requested review from arya2 arya2 is a code owner automatically assigned from ZcashFoundation/devops-reviewers

Assignees

@gustavovalverde gustavovalverde

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-slow Problems with performance or responsiveness
Projects
None yet
Milestone
No milestone
2 participants
@gustavovalverde @teor2345