Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(doc): Add instructions for new placeholder crates #7751

Merged
merged 2 commits into from
Oct 17, 2023
Merged

change(doc): Add instructions for new placeholder crates #7751

merged 2 commits into from
Oct 17, 2023

Conversation

teor2345
Copy link
Contributor

Motivation

This PR documents how to create new placeholder crates.

Review

@oxarbitrage is going to try this out.

Reviewer Checklist

  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added A-docs Area: Documentation C-enhancement Category: This is an improvement P-Low ❄️ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG A-release Area: Zebra releases and release management labels Oct 16, 2023
@teor2345 teor2345 requested a review from a team as a code owner October 16, 2023 22:34
@teor2345 teor2345 self-assigned this Oct 16, 2023
@teor2345 teor2345 requested review from oxarbitrage and removed request for a team October 16, 2023 22:34
oxarbitrage
oxarbitrage reviewed Oct 17, 2023
View reviewed changes
book/src/dev/crate-owners.md Outdated Show resolved Hide resolved
book/src/dev/crate-owners.md Outdated Show resolved Hide resolved
oxarbitrage
oxarbitrage approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, i published the placeholder https://crates.io/crates/zebra-scanner following the instructions. I made a few minor changes at 06a06f6

mergify bot added a commit that referenced this pull request Oct 17, 2023
@mergify
Merge of #7751
d4c7b08
@mergify mergify bot mentioned this pull request Oct 17, 2023
Closed
@mergify mergify bot merged commit bea90df into main Oct 17, 2023
69 checks passed
@mergify mergify bot deleted the placeholder-crates branch October 17, 2023 21:54
@teor2345 teor2345 mentioned this pull request Nov 5, 2023
Merged
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

Assignees

@teor2345 teor2345

Labels
A-docs Area: Documentation A-release Area: Zebra releases and release management C-enhancement Category: This is an improvement C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teor2345 @oxarbitrage