-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(scan): Use the on-disk database for keys and results #8036
Conversation
61d4924
to
4c36f20
Compare
After i approved #8031 and it gor merged the automatic rebase into main didnt worked very well. The commits were repeated and there were conflicts. I cherry picked the relevant commits and force pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks GREAT!
Unavailable gcloud service https://github.com/ZcashFoundation/zebra/actions/runs/7051128803/job/19193339040?pr=8036 Trying a refresh. |
@Mergifyio refresh |
✅ Pull request refreshed |
Refresh didn't worked so i sent a small doc change to trigger the CI again. d216d03 |
Motivation
This PR replaces the in-memory database with a database on disk.
Depends-On: #8031
Close #8019
The remaining checklist items in that ticket actually belong in other tickets.
PR Author Checklist
Check before marking the PR as ready for review:
For significant changes:
If a checkbox isn't relevant to the PR, mark it as done.
Specifications
The design is in ticket #8019.
Complex Code or Requirements
The "get all keys" code is a bit messy, we can fix it up after the MVP when we have a column family just for keys.
Solution
Testing
I updated the existing tests, and marked the functions that need tests with a TODO. We can do those tests in the PRs where we actually use those functions, because we might change how those functions work when we start using them.
Review
This is a routine scanner database change.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work
And then: