Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consensus): Check Equihash solutions with n=200, k=9 parameters #8474

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Apr 29, 2024

Motivation

This always checks Equihash solutions with the Mainnet/Testnet parameters, even if Zebra receives a block with a shorter Equihash solution. This is fine for Regtest for now since it skips the Proof-of-Work check altogether.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?
For significant changes:
  • Is there a summary in the CHANGELOG?
  • Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

  • Reverts a change that allows for validating Equihash solutions with easier parameters on Mainnet and Testnet

Review

Anyone can review.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

Add a field on testnet::Parameters for defining a network's Equihash parameters

@arya2 arya2 added C-bug Category: This is a bug A-consensus Area: Consensus rule updates I-consensus Zebra breaks a Zcash consensus rule P-Medium ⚡ labels Apr 29, 2024
@arya2 arya2 self-assigned this Apr 29, 2024
@arya2 arya2 requested a review from a team as a code owner April 29, 2024 20:52
@arya2 arya2 requested review from upbqdn and removed request for a team April 29, 2024 20:52
@mergify mergify bot merged commit 7893874 into main Apr 29, 2024
137 checks passed
@mergify mergify bot deleted the use-common-equihash-params branch April 29, 2024 23:04
@upbqdn upbqdn mentioned this pull request May 6, 2024
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates C-bug Category: This is a bug I-consensus Zebra breaks a Zcash consensus rule P-Medium ⚡
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants