Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): sample configurations in the custom testnet book page #8794

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

oxarbitrage
Copy link
Contributor

@oxarbitrage oxarbitrage commented Aug 21, 2024

Motivation

I tried to launch some custom testnets and i found a few small issues in the docs, with the sample configurations provided.

Solution

Small modifications so the provided configs can be just pasted into a file and used to launch zebra. Initial peers field was added, with an empty list or:

error: zebrad fatal error: parse error: cannot use default initials peers with incompatible testnet for key `network` at line 44 column 1

Tests

Manual, both configurations now are valid and start zebrad.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@oxarbitrage oxarbitrage added A-docs Area: Documentation C-testing Category: These are tests P-Low ❄️ labels Aug 21, 2024
@oxarbitrage oxarbitrage requested a review from a team as a code owner August 21, 2024 20:45
@oxarbitrage oxarbitrage requested review from arya2 and removed request for a team August 21, 2024 20:45
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Aug 21, 2024
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@mergify mergify bot merged commit cccf98b into main Aug 21, 2024
95 checks passed
@mergify mergify bot deleted the fix-sample-config-custom-testnet-docs branch August 21, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants