Sapling - Ledger, Ledger X #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Also add Ledger X Support
This was referenced Jun 29, 2019
|
Someone needs to review this pull request |
VictorLux
approved these changes
Jun 30, 2019
|
It can be tested, manually loading onto a ledger with command line. If someone has a ledger PM me on telegram @justjamesdev and I'll supply binaries with instructions. However, its true that the only test really required here is that existing Electrum functionality is fine, since ledger does not currently work anyway, they have raised it with me a few times now. What needs to happen is a release. Maybe servers need updating too before release ? |
VictorLux
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the Bittrex delist people may have funds locked in ledger since it has not worked correctly since the sapling update. I hope this will help some people.
This change adds support for in the Ledger plugin within Electrum as per zCash, and is a precursor to Ledger change, It also adds Ledger X Support.