[fetch_navigation][melodic] add launch_map_server argument in fetch_nav.launch #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @knorth55, Thanks for the PR! My inclination is to leave the default for the added param as False, instead of True. This makes it simple to launch the fetch_navigation with defaults, with or without a map server running. For example, we do this when building a map: http://docs.fetchrobotics.com/navigation.html Does that quick change sound reasonable on your end? |
|
I set |
|
I apparently can't read, you are correct. 😅 |
erelson
approved these changes
Aug 2, 2020
ChamzasKonstantinos
added a commit
to KavrakiLab/fetch_ros
that referenced
this pull request
Oct 8, 2021
* add use_map_topic arg in fetch_nav.launch (ZebraDevs#145) * add launch_map_server argument in fetch_nav.launch (ZebraDevs#147) * Python2/3 agnostic tweak * Fix tuck arm moveit check [OPEN-48] (ZebraDevs#150) * Add srdf file path argument to move_group.launch * Use xacro to load fetch.srdf * Manually revert textures on URDF models (ZebraDevs#154) * [fetch_teleop][melodic] update collision objects to avoid collision (ZebraDevs#132) * move collision objects to avoid collision * use mesh for tuck arm collision * Preparing for release * 0.8.3 Co-authored-by: Shingo Kitagawa <knorth55@users.noreply.github.com> Co-authored-by: Eric Relson <erelson@fetchrobotics.com> Co-authored-by: Jeff Wilson <jwilson@fetchrobotics.com> Co-authored-by: Naoya Yamaguchi <708yamaguchi@gmail.com> Co-authored-by: Carl Saldanha <cjds@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
melodic version of #146
add
launch_map_serverargument infetch_nav.launchwe use this commit to use other map server, such as
multi_map_server.we don't have fetch with melodic, so we haven't tested on a real robot.
cc. @708yamaguchi