-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow configuring menu toggle button #181
Conversation
I think this PR is in a good state, if you change it to not be a draft PR I'll try to get some testing done and would be happy to merge it if that goes well. I didn't see anything in the PR to hide the input in the keyboard mapping UI, but I can help take care of that if it's not already the case. |
Looks like CI failed due to needing a rebase, would you be able to rebase the PR on top of the current dev branch? |
126205f
to
60f57ff
Compare
yeah, i hadn't looked into that because i wasn't sure if that was a desired solution (or if actually implementing keyboard key configuration for toggle would be a similar lift) |
I think it'd make sense to leave escape immutable as the menu key, it prevents you from ever getting locked into a binding since it also acts as the button to cancel an input binding. I don't think not being able to bind escape is a dealbreaker for anyone. |
07e70fb
to
f493c59
Compare
i implemented logic to hide the keyboard binding by using a |
That's a good solution. I did notice an issue if you have an existing controls.json file (as in you've played on a previous version), when you run this version the menu button is unbound. The fix is pretty straightforward, change the |
i updated |
b208afa
to
25f11f0
Compare
25f11f0
to
f160f1e
Compare
Thanks for the contribution, this is a great feature to have! |
what this does
SDL_CONTROLLER_BUTTON_BACK
for menu togglingwhat this doesn't do