feat: allow configuring menu toggle button

[briaguya-ai]

what this does

• allows users to configure the controller button(s) used to toggle the recomp config menu
  • seems to be a requested feature cant change what button opens the menu #24
  • specifically a problem for certain controllers Switch N64 Controller C-Right Binding Issue (ALSO: GC Controller L & R Triggers Broken) #41
• removes hardcoded references to SDL_CONTROLLER_BUTTON_BACK for menu toggling

what this doesn't do

• anything that lets users configure what keyboard key is used to toggle the menu

[Mr-Wiseguy]

I think this PR is in a good state, if you change it to not be a draft PR I'll try to get some testing done and would be happy to merge it if that goes well. I didn't see anything in the PR to hide the input in the keyboard mapping UI, but I can help take care of that if it's not already the case.

[Mr-Wiseguy]

Looks like CI failed due to needing a rebase, would you be able to rebase the PR on top of the current dev branch?

[briaguya-ai]

I didn't see anything in the PR to hide the input in the keyboard mapping UI

yeah, i hadn't looked into that because i wasn't sure if that was a desired solution (or if actually implementing keyboard key configuration for toggle would be a similar lift)

[Mr-Wiseguy]

I think it'd make sense to leave escape immutable as the menu key, it prevents you from ever getting locked into a binding since it also acts as the button to cancel an input binding. I don't think not being able to bind escape is a dealbreaker for anyone.

[briaguya-ai]

i implemented logic to hide the keyboard binding by using a data-if in controls.rml. this felt like the least invasive way to do it, but it means the binding is still defined, just hidden.

[Mr-Wiseguy]

That's a good solution. I did notice an issue if you have an existing controls.json file (as in you've played on a previous version), when you run this version the menu button is unbound. The fix is pretty straightforward, change the continue in load_input_device_from_json to load the default binding instead. I'd pass the default bindings for the current device in as an extra argument to that function and make some sort of switch case to get the default binding for a given GameInput.

[briaguya-ai]

i updated load_input_device_from_json to add defaults. i needed a way to get from a GameInput enum value to the member on the DefaultN64Mappings struct so i added get_default_mapping_for_input

[Mr-Wiseguy]

Thanks for the contribution, this is a great feature to have!