Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Skull Kid curse effect in ultrawide (32:9+) #259

Merged
merged 1 commit into from
May 26, 2024
Merged

Conversation

Reonu
Copy link
Collaborator

@Reonu Reonu commented May 25, 2024

The Skull Kid curse effect seemed to be fine in widescreen / ultrawide, but it turns out at extremely wide aspect ratios like 32:9 it does get cut off. Therefore, I've replaced the meshes (it uses 2 DLs!) in a similar way to what I did with the ocarina effects.

The particular function used to render this effect (EffStk_Draw) already had patches applied to it in effect_transform_tagging.c. So I just added my patches to the existing patched function. However, this patch involves adding 2 arrays of vertices and a 2 new DLs, so in order to avoid clutter in that file, I moved the function over to ocarina_effect_patches.c with the other patches for the widescreen ocarina effects. This means it's the only function in this file to be patched for more stuff than just widescreen (I think), but I think that's better than cluttering effect_transform_tagging.c up.

Anyways. Here's the effect in all its W I D E glory:

Video_2024-05-25_00-59-54-00.00.05.970-00.00.15.320.mp4

@Reonu Reonu merged commit 332a45c into dev May 26, 2024
5 checks passed
@dcvz dcvz deleted the skull_kid_curse branch May 26, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant