Fix Skull Kid curse effect in ultrawide (32:9+) #259
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Skull Kid curse effect seemed to be fine in widescreen / ultrawide, but it turns out at extremely wide aspect ratios like 32:9 it does get cut off. Therefore, I've replaced the meshes (it uses 2 DLs!) in a similar way to what I did with the ocarina effects.
The particular function used to render this effect (
EffStk_Draw
) already had patches applied to it ineffect_transform_tagging.c
. So I just added my patches to the existing patched function. However, this patch involves adding 2 arrays of vertices and a 2 new DLs, so in order to avoid clutter in that file, I moved the function over toocarina_effect_patches.c
with the other patches for the widescreen ocarina effects. This means it's the only function in this file to be patched for more stuff than just widescreen (I think), but I think that's better than clutteringeffect_transform_tagging.c
up.Anyways. Here's the effect in all its W I D E glory:
Video_2024-05-25_00-59-54-00.00.05.970-00.00.15.320.mp4