Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve (de)serialization #159

Merged
merged 3 commits into from
Dec 28, 2021
Merged

Improve (de)serialization #159

merged 3 commits into from
Dec 28, 2021

Conversation

survived
Copy link
Contributor

@survived survived commented Dec 21, 2021 •
edited
Loading

  • Fixes point/scalar deserialization with bincode
  • Serializes points/scalars/bigints in hex format if serialization format is human readable

Closes #158

@survived survived force-pushed the bincode-serde-issues branch 3 times, most recently from fb93982 to 717f9ef Compare December 22, 2021 07:21
@survived survived marked this pull request as ready for review December 22, 2021 07:27
elichai
elichai approved these changes Dec 28, 2021
View reviewed changes
Copy link
Contributor

@elichai elichai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elichai elichai merged commit 44537a7 into master Dec 28, 2021
@elichai elichai deleted the bincode-serde-issues branch December 28, 2021 10:39
@xcshuan
Copy link

xcshuan commented Aug 12, 2022 •
edited
Loading

Can a release be made with this fix? such as 0.9.1？ @elichai which I think would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elichai elichai elichai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serialization doesn't work with bincode
3 participants
@survived @xcshuan @elichai