Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schnorr support #9

Merged
merged 16 commits into from
Dec 26, 2018
Merged

Schnorr support #9

merged 16 commits into from
Dec 26, 2018

Conversation

omershlo
Copy link
Contributor

No description provided.

@gbenattar
Copy link
Contributor

As discussed, this branch is ready for merging with master. @omershlo can you please provide a very descriptive bullet list with everything that is included? I will squash and merge.

@omershlo
Copy link
Contributor Author

omershlo commented Dec 6, 2018

@gbenattar sure :

  • Schnorr support: The code now supports both 2 party ecdsa and 2 party schnorr based on secp256k1 elliptic curve
  • As a result of the previous bullet some design changes were introduced. most notably HD (get child) functionality and rotate functionality became traits and implemented per dsa
  • The common parts of those become common functions
  • other than that this branch was updated mainly to support changes in ecdsa, schnorr and curv repos. The one worth mentioning is a change to expose full structs publicly for ser/des

@omershlo
Copy link
Contributor Author

omershlo commented Dec 7, 2018

the latest commit is a minor change in the interface of ecdsa signing to support concurrent running. the change reflects in party two ephemeral second message such that instead of argument of dlog_proof the argument is the entire first message from party one

@omershlo omershlo merged commit db9fc9f into master Dec 26, 2018
@omershlo omershlo deleted the schnorr_support branch December 26, 2018 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants