feat(SharePanel, PreviewCard): add author info and optimize view #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit eb08cde): https://staging-zenuml-27954--pr602-feature-share-previe-3dc0s8ge.web.app (expires Tue, 14 Nov 2023 11:59:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6b46293b8a64352bd380930ba2a9594929b524e6 |
|
Can you please add "copied" feedback on the "Copy Link" button? Here is an example from Confluence page: Let me know if you think it should be a separate card. |
feat(PreviewCard, SharePanel): Add tutorial image and change props refactor(components): Update props in SharePanel and ContentWrap feat(Popover): Enhance popover with new props and use it as a tooltip on copy link button
dontry
force-pushed
the
feature/share-preview-card
branch
from
fcbca07
to
428bc5e
Compare
dontry
force-pushed
the
feature/share-preview-card
branch
from
b7edebc
to
9b1e34c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the share preview card based on the new confluence card style.
Fixes: #556