-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for units that can repair other units #43
Comments
I'm interested in working on this. |
Glad you're tackling this! I'd say keep it inline with repair. I'll write
up some more general notes on this tomorrow too.
…On Wed, Mar 1, 2017 at 5:30 PM, tcmb ***@***.***> wrote:
Would you prefer that repairing other units be called something distinct
like "heal" or keep it in line with "repair?" I just started digging into
the code and wanted to know what you were envisioning.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#43 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAEVsJ2FsBdJ6Hn-6QEu_MrUlv38eMxks5rhf-jgaJpZM4LiMSp>
.
|
Cool, looking forward to it. |
I added some tasks to the description to point you in the right direction. It's possible I missed something, but I think that list is pretty complete. I realize it's quite a bit to absorb. Adding a new action to the game is one of the more involved changes you can make. Don't panic though. Just take them one at a time and I'm sure you can get through it. Feel free to ask questions or request code reviews as you go. Good luck! |
There are some bugs, but I have a version of the feature and I'd appreciate your feedback. Would you like to do it through a pull request or just check my repo? |
Nice! A pull request sounds good. That way I can add comments and such. |
I added a couple of commits to my pull request. Sorry for any possible confusion. |
No worries. I'm busy today, but I'll take look tomorrow and give you some
feedback.
…On Mar 4, 2017 11:44 PM, "tcmb" ***@***.***> wrote:
I added a couple of commits to my pull request. Sorry for any possible
confusion.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#43 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAEVmPmw0lDYXSlDuNRPJm-bQlY8eTFks5rihVrgaJpZM4LiMSp>
.
|
This issue should probably be closed now. |
This one is a little involved. To do this you need to:
I suggest we call the action :action.type/repair-other-unit and the event :zetawar.ui.events/repair-targeted.
The text was updated successfully, but these errors were encountered: