Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POS: add ability and associate existing payments with open orders and hide open orders #1454

Merged
merged 12 commits into from
May 15, 2023

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented May 6, 2023

Description

On the POS orders list, items can now be slided to the left to expose a payment and delete button. The delete button will hide the order from the open orders list. This is useful for removing orders that customer were unable to pay. The payment button will take the server to the activity list (filtered only to received payments) to associate a made payment with an order.

Simulator Screen Shot - iPad Pro (12 9-inch) (4th generation) - 2023-05-06 at 19 16 38
Simulator Screen Shot - iPad Pro (12 9-inch) (4th generation) - 2023-05-09 at 17 02 16

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • Core Lightning (Spark)
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis changed the title POS: add ability to hide orders POS: add ability and associate existing payments with open orders and hide open orders May 6, 2023
@kaloudis kaloudis marked this pull request as draft May 7, 2023 03:23
@kaloudis kaloudis marked this pull request as ready for review May 9, 2023 21:03
@kaloudis kaloudis added this to the v0.7.6 milestone May 15, 2023
@kaloudis kaloudis merged commit cee7237 into ZeusLN:master May 15, 2023
@kaloudis kaloudis deleted the pos-hide-orders branch May 15, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant