Edit channel fees: fix showing feedback after fees have been set

[myxmaster]

Description

This finally fixes #420.

Additionally renamed ChannelsStore.getChannelInfo function to loadChannelInfo since it does not return a value and get functions usually do.

Now displaying loading indicator instead of button:

And displaying result message below button:

This pull request is categorized as a:

• New feature
• Bug fix
• Code refactor
• Configuration change
• Locales update
• Quality assurance
• Other

Checklist

• I’ve run yarn run tsc and made sure my code compiles correctly
• I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
• I’ve run yarn run prettier and made sure my code is formatted correctly
• I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

• No, I’m a fool
• Yes
• N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

• Android
• iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

• Embedded LND
• LND (REST)
• LND (Lightning Node Connect)
• Core Lightning (c-lightning-REST)
• LndHub
• [DEPRECATED] Core Lightning (Spark)
• [DEPRECATED] Eclair

Locales

• I’ve added new locale text that requires translations
• I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

• Contributors will need to run yarn after this PR is merged in
• 3rd party dependencies have been modified:
  • verify that package.json and yarn.lock have been properly updated
  • verify that dependencies are installed for both iOS and Android platforms

Other:

• Changes were made that require an update to the README
• Changes were made that require an update to onboarding

[shubhamkmr04]

Observed a weird behavior when we got back to Channel view after submitting fees

Screen.Recording.2023-10-05.at.6.13.31.PM.mov

[myxmaster]

Good catch. This is mostlikely fixed by the removed KeyboardAvoidingView in PR #1657 though. Can you merge both commits? Otherwise please pull #1657 and then I will solve conflicts and do a force-push for #1738.

[myxmaster]

Just tested this. As expected that scrolling issue is gone with PR #1657.

[shubhamkmr04]

Just tested this. As expected that scrolling issue is gone with PR #1657.

Yup, it's gone. Thanks!