Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CollapsedQR: Tap to enlarge QR #1850

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

myxmaster
Copy link
Contributor

@myxmaster myxmaster commented Nov 16, 2023

Description

Due to scanning issues caused by several factors (overall QR size, small quietZone, low contrast because of new theme colors) this adds ability to tap on the QR to enlarge it to fullscreen. It will also use black/white colors and increase quietZone. To go back to normal mode you can tap anywhere.

QuietZone is now relative to screensize (before it was relatively smaller for bigger screens) and normal size of QR (before tapping) is now slightly smaller.

Before:
Phone:
grafik

Tablet:
grafik

After:
Phone:
grafik

Tablet:
grafik

This will also fix #1604.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • LndHub
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! I think we should combine this with @kaloudis's PR; maybe we can tap to toggle it to white and hold the QR to enlarge it

@myxmaster
Copy link
Contributor Author

maybe we can tap to toggle it to white and hold the QR to enlarge it

Not a bad idea either, but I talked to @kaloudis before doing this and we thought about using hold (long tap) for copying QR image to clipboard. Not sure about that yet, but I think making it large and black/white is totally fine to combine. Intention is to make scanning more easy with the tap and both helps for this.

Copy link
Contributor

@kaloudis kaloudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit d285e76 into ZeusLN:master Nov 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QR codes: "Quiet zone" should be increased to 4 modules
3 participants