Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to scanning issues caused by several factors (overall QR size, small quietZone, low contrast because of new theme colors) this adds ability to tap on the QR to enlarge it to fullscreen. It will also use black/white colors and increase quietZone. To go back to normal mode you can tap anywhere.
QuietZone is now relative to screensize (before it was relatively smaller for bigger screens) and normal size of QR (before tapping) is now slightly smaller.
Before:
![grafik](https://private-user-images.githubusercontent.com/77545287/283306586-e38b0621-e026-4480-85e2-c9510693f782.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxMzU4MzQsIm5iZiI6MTcyMjEzNTUzNCwicGF0aCI6Ii83NzU0NTI4Ny8yODMzMDY1ODYtZTM4YjA2MjEtZTAyNi00NDgwLTg1ZTItYzk1MTA2OTNmNzgyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI4VDAyNTg1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWYzODhhYTU3MjA2YTg4MGM0Y2Y0ZGIwYmNlODg0NWRkMGU2NWYzMDFmNjEzMDM3NjZjM2VjZGNkYzgyNmFkNGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.VyPj4sADuZEPLtNyTmXc5n5KAnCCNivlFAhKlqkcaoY)
Phone:
Tablet:
![grafik](https://private-user-images.githubusercontent.com/77545287/283306726-79307e95-51ce-4c7a-8188-ff1c44ed2deb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxMzU4MzQsIm5iZiI6MTcyMjEzNTUzNCwicGF0aCI6Ii83NzU0NTI4Ny8yODMzMDY3MjYtNzkzMDdlOTUtNTFjZS00YzdhLTgxODgtZmYxYzQ0ZWQyZGViLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI4VDAyNTg1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWMzOWI3YjFkNzRiYjdkZmFiN2ExOGRkNDE1MzdmMDBmMTcwNjFkN2Y5ODljODFkYzZhOThlZWE5MWNiM2I0ZmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.kbpI7tTLP6yH6eOyZKDZe2t-oaoE8fCEc2kSNv6-nwk)
After:
![grafik](https://private-user-images.githubusercontent.com/77545287/283306087-514e6f9e-8243-42cd-ac29-01f5d147a3c6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxMzU4MzQsIm5iZiI6MTcyMjEzNTUzNCwicGF0aCI6Ii83NzU0NTI4Ny8yODMzMDYwODctNTE0ZTZmOWUtODI0My00MmNkLWFjMjktMDFmNWQxNDdhM2M2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI4VDAyNTg1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTMzZDI4NDliZWFlNzIwYjExYWZjNDAwZGRkMjFhNjBlYmI2Mzk1MWIyZDQyMGUzNDdjZmNhNzA1MzNlMzUwYzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.GWCoWJpYcFnAjevVzYWxJykhT85X1jszUDl3aaAI4c8)
Phone:
Tablet:
![grafik](https://private-user-images.githubusercontent.com/77545287/283306154-a4de9a2c-7c90-43ce-9b23-2c66a091612d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxMzU4MzQsIm5iZiI6MTcyMjEzNTUzNCwicGF0aCI6Ii83NzU0NTI4Ny8yODMzMDYxNTQtYTRkZTlhMmMtN2M5MC00M2NlLTliMjMtMmM2NmEwOTE2MTJkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI4VDAyNTg1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI2ZTg2MDE2MmQzNjkzNGNiN2E4YjQ5MzI0MTgwY2JlMGRkMjg2OGY2OWVmNmVhZDBhNWE0ZWRhMzJhYzMwZDgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ADwFeDQvntQwsJ6qBkSaSxxV3EnAFYi1DYMeHtz6Bq8)
This will also fix #1604.
This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: