Fix updating colors on theme change

[myxmaster]

Description

This fixes #1659 by moving themeColor() calls from static style objects to render methods.

Remove color from RoutingHeader completely as it has no effect.

This pull request is categorized as a:

• New feature
• Bug fix
• Code refactor
• Configuration change
• Locales update
• Quality assurance
• Other

Checklist

• I’ve run yarn run tsc and made sure my code compiles correctly
• I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
• I’ve run yarn run prettier and made sure my code is formatted correctly
• I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

• No, I’m a fool
• Yes
• N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

• Android
• iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

• Embedded LND
• LND (REST)
• LND (Lightning Node Connect)
• Core Lightning (c-lightning-REST)
• LndHub
• [DEPRECATED] Core Lightning (Spark)
• [DEPRECATED] Eclair

Locales

• I’ve added new locale text that requires translations
• I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

• Contributors will need to run yarn after this PR is merged in
• 3rd party dependencies have been modified:
  • verify that package.json and yarn.lock have been properly updated
  • verify that dependencies are installed for both iOS and Android platforms

Other:

• Changes were made that require an update to the README
• Changes were made that require an update to onboarding

[myxmaster]

Created a script and workflow to ensure static styles don't contain themeColor() calls. Also extended PR template.

[shubhamkmr04]

Should I be able to use yarn run check-styles now? Or do I need to do something differently here? Please let me know.

[kaloudis]

Should I be able to use yarn run check-styles now? Or do I need to do something differently here? Please let me know.

I bet we're hitting an issue w/ Windows/UNIX differences

[kaloudis]

if this is now covered by yarn run lint, we can remove this here

[myxmaster]

right, done

[kaloudis]

tACK - have tested this with lint errors and the newly added theme/style errors. Have also tested this against our Docker build script

Very nice addition, will help us a good bit I think as evidenced by all the instances found. Nice work.