-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix updating colors on theme change #1870
Conversation
cd3623e
to
3bba480
Compare
Created a script and workflow to ensure static styles don't contain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
13d2cf4
to
7a852d7
Compare
.github/PULL_REQUEST_TEMPLATE.md
Outdated
- [ ] Other | ||
|
||
## Checklist | ||
- [ ] I’ve run `yarn run tsc` and made sure my code compiles correctly | ||
- [ ] I’ve run `yarn run lint` and made sure my code didn’t contain any problematic patterns | ||
- [ ] I’ve run `yarn run prettier` and made sure my code is formatted correctly | ||
- [ ] I’ve run `yarn run test` and made sure all of the tests pass | ||
- [ ] I’ve run `yarn run check-styles` and made sure all of the static styles don't contain themeColor() calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is now covered by yarn run lint
, we can remove this here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, done
7a852d7
to
594859d
Compare
…, use node 18 in workflows
594859d
to
a2ed49d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK - have tested this with lint errors and the newly added theme/style errors. Have also tested this against our Docker build script
Very nice addition, will help us a good bit I think as evidenced by all the instances found. Nice work.
Description
This fixes #1659 by moving themeColor() calls from static style objects to render methods.
Remove color from RoutingHeader completely as it has no effect.
This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: