Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/242/add partner tickets #434

Closed
wants to merge 26 commits into from

Conversation

ninewise
Copy link
Member

Add quick invitations, fix most of #242

  • Authenticate with tokens.
  • Write decent mails.
  • Test it.

@maartenhbe
Copy link
Collaborator

If you want, I can write the mails if this saves you time.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 561d0ea on feature/242/add-partner-tickets into 5aa846e on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 561d0ea on feature/242/add-partner-tickets into 5aa846e on master.

@ninewise
Copy link
Member Author

@maartenhbe if you could, that'd be nice. After all, even if I write them, you'd still have to correct them.

@maartenhbe
Copy link
Collaborator

Check! Which files do I need to edit? Which placeholders are required?

@ninewise
Copy link
Member Author

The two in app/views/partner_mailer/. For the link, just place something like "<<>>". Basically the send_token mail will send a login link for the partner. The invitation mail will send a link to a confirmation page, where the user is logged in automatically, and can accept the invitation. Upon which he'll get his ticket/payment mail.

@maartenhbe
Copy link
Collaborator

Already wrote the invitation mail. I also included some event details details to make it more appealing as in the other mails. You might need to include an extra model for those details.

@maartenhbe
Copy link
Collaborator

Done.

I added an extra placeholder in the token mail to display the number of tickets allowed. If this isn't possible, just delete that ;)

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling ca3519c on feature/242/add-partner-tickets into 5aa846e on master.

@TomNaessens
Copy link
Member

I don't understand some things here:

  • Why is it possible to sent multiple tickets to one partner? This is functionality that should only be available in the advanced view.

@ninewise
Copy link
Member Author

Because this was a fast prototype, to provide nearly all functionality as fast as possible. Now that there is less haste, I'm working on the advanced view, which will make this superfluous.

@maartenhbe
Copy link
Collaborator

It should be possible though to send multiple tickets to a single partner ;)

@TomNaessens
Copy link
Member

Even for the basic version?

On 15 Mar 2014 at 23:30:18, Maarten (notifications@github.com) wrote:

It should be possible though to send multiple tickets to a single partner ;)


Reply to this email directly or view it on GitHub.

@maartenhbe
Copy link
Collaborator

Preferably yes. Unless it's possible to e.g. generate 10 promolinks to let a partner register 10 different tickets or mail the link to their bussiness partners.

@ninewise
Copy link
Member Author

Not yet, that's the advanced system.

1 similar comment
@ninewise
Copy link
Member Author

Not yet, that's the advanced system.

@ninewise ninewise closed this Jun 21, 2020
@TomNaessens TomNaessens deleted the feature/242/add-partner-tickets branch October 2, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants