Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduced EBV Partition Algorithm #179

Merged
merged 14 commits into from
Jan 26, 2022
Merged

Introduced EBV Partition Algorithm #179

merged 14 commits into from
Jan 26, 2022

Conversation

ZigRazor
Copy link
Owner

Signed-off-by: ZigRazor zigrazor@gmail.com

Implement #177

@ZigRazor
Introduced EBV Partition Algorithm
00721d2 
Signed-off-by: ZigRazor <zigrazor@gmail.com>
@ZigRazor ZigRazor self-assigned this Jan 21, 2022
@ghost
Copy link

ghost commented Jan 21, 2022 •
edited by ghost

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

@github-actions github-actions bot added core something about core test Something about test labels Jan 21, 2022
@ZigRazor ZigRazor added development Development of new Functionalities enhancement New feature or request and removed test Something about test core something about core labels Jan 21, 2022
@ZigRazor ZigRazor added this to In progress in New Functionalities via automation Jan 21, 2022
@ZigRazor ZigRazor linked an issue Jan 21, 2022 that may be closed by this pull request
Add EBV Partition Algorithm #177
Closed
@ZigRazor
Added description for EBV on README.md
8cec616 
Signed-off-by: ZigRazor <zigrazor@gmail.com>
@github-actions github-actions bot added core something about core repo something about repo test Something about test labels Jan 21, 2022
@lgtm-com
Copy link

lgtm-com bot commented Jan 21, 2022

This pull request introduces 2 alerts when merging 8cec616 into ab5432d - view on LGTM.com

new alerts:

  • 1 for Resource not released in destructor
  • 1 for Catching by value

@ZigRazor
Updated Code_Coverage Workflow
4569794 
Signed-off-by: ZigRazor <zigrazor@gmail.com>
@github-actions github-actions bot added the automated workflows Automated Workflows label Jan 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2022 •
edited

Codecov Report

Merging #179 (61ea623) into master (dce00a7) will decrease coverage by 0.00%.
The diff coverage is 90.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   97.15%   97.15%   -0.01%     
==========================================
  Files          41       45       +4     
  Lines        4748     5162     +414     
==========================================
+ Hits         4613     5015     +402     
- Misses        135      147      +12
Flag Coverage Δ
unittests 97.15% <90.48%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/Graph/Graph_TS.hpp 43.47% <0.00%> (ø)
include/Partitioning/CoordinatedRecord.hpp 82.60% <ø> (+6.60%) ⬆️
include/Partitioning/Partition.hpp 80.00% <ø> (+6.31%) ⬆️
test/main.cpp 100.00% <ø> (ø)
include/Partitioning/CoordinatedPartitionState.hpp 62.50% <58.82%> (-3.08%) ⬇️
include/Partitioning/HDRF.hpp 81.31% <80.43%> (+10.05%) ⬆️
include/Partitioning/EBV.hpp 88.05% <88.05%> (ø)
include/Partitioning/GreedyVertexCut.hpp 89.79% <89.79%> (ø)
include/Partitioning/EdgeBalancedVertexCut.hpp 90.19% <90.19%> (ø)
include/Graph/Graph.hpp 98.04% <100.00%> (+0.01%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab5432d...61ea623. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jan 21, 2022

This pull request introduces 2 alerts when merging 4569794 into ab5432d - view on LGTM.com

new alerts:

  • 1 for Resource not released in destructor
  • 1 for Catching by value

@ZigRazor
Solved some issues
d3281ed 
Signed-off-by: GitHub <noreply@github.com>
@ZigRazor
Resources Released for partitioner
fffff19 
Signed-off-by: ZigRazor <zigrazor@gmail.com>
@ZigRazor
Corrected command for benchmark
740b9cf 
Fix #173

Signed-off-by: ZigRazor <zigrazor@gmail.com>
@ZigRazor
Added Copy Costructor for Partitioner
c393d2e 
Signed-off-by: ZigRazor <zigrazor@gmail.com>
@ZigRazor
Substituted usleep
56094ca 
Signed-off-by: ZigRazor <zigrazor@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2022

This pull request fixes 6 alerts when merging 56094ca into ab5432d - view on LGTM.com

fixed alerts:

  • 3 for Resource not released in destructor
  • 3 for Catching by value

@ZigRazor
Corrected a little bug, and declared explicit constructor
d248030 
Signed-off-by: ZigRazor <zigrazor@gmail.com>
@ZigRazor
Fixed benchmark
0487e5e 
Fix #173

Signed-off-by: ZigRazor <zigrazor@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2022

This pull request fixes 6 alerts when merging 0487e5e into ab5432d - view on LGTM.com

fixed alerts:

  • 3 for Resource not released in destructor
  • 3 for Catching by value

@ZigRazor
Resolved some little bugs.
a780f14 
Signed-off-by: ZigRazor <zigrazor@gmail.com>
New Functionalities automation moved this from In progress to Review in progress Jan 24, 2022
AlfredCP
AlfredCP suggested changes Jan 24, 2022
View reviewed changes
benchmark/Utilities.hpp Show resolved Hide resolved
include/Partitioning/CoordinatedPartitionState.hpp Outdated Show resolved Hide resolved
include/Partitioning/EBV.hpp Outdated Show resolved Hide resolved
include/Partitioning/EdgeBalancedVertexCut.hpp Outdated Show resolved Hide resolved
include/Partitioning/GreedyVertexCut.hpp Outdated Show resolved Hide resolved
include/Partitioning/HDRF.hpp Outdated Show resolved Hide resolved
test/PartitionTest.cpp Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2022

This pull request fixes 9 alerts when merging a780f14 into ab5432d - view on LGTM.com

fixed alerts:

  • 6 for Resource not released in destructor
  • 3 for Catching by value

@ZigRazor
Correct the mechanism to avoid deadlock in Partition
2ad39b9 
Resolved conversation

Signed-off-by: ZigRazor <zigrazor@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2022

This pull request fixes 9 alerts when merging 2ad39b9 into ab5432d - view on LGTM.com

fixed alerts:

  • 6 for Resource not released in destructor
  • 3 for Catching by value

@ZigRazor
Solved initialization on constructor for shared_ptr Mutex
61ea623 
Signed-off-by: ZigRazor <zigrazor@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2022

This pull request fixes 9 alerts when merging 61ea623 into ab5432d - view on LGTM.com

fixed alerts:

  • 6 for Resource not released in destructor
  • 3 for Catching by value

@ZigRazor ZigRazor linked an issue Jan 24, 2022 that may be closed by this pull request
Benchmark workflow does not work! #173
Closed
@ZigRazor
Corrected and tested the recreate graph from input file
1b22b7b 
Fix #164

Discussion #140

Signed-off-by: ZigRazor <zigrazor@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2022

This pull request fixes 9 alerts when merging 1b22b7b into ab5432d - view on LGTM.com

fixed alerts:

  • 6 for Resource not released in destructor
  • 3 for Catching by value

@ZigRazor ZigRazor linked an issue Jan 24, 2022 that may be closed by this pull request
readFromStandardFile implementation #164
Closed
@ZigRazor ZigRazor merged commit dfc36b4 into master Jan 26, 2022
New Functionalities automation moved this from Review in progress to Done Jan 26, 2022
@ZigRazor ZigRazor deleted the EBV branch January 26, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavan-pan pavan-pan Awaiting requested review from pavan-pan

@sidml sidml Awaiting requested review from sidml

@AlfredCP AlfredCP Awaiting requested review from AlfredCP

Assignees

@pavan-pan pavan-pan

@ZigRazor ZigRazor

@sidml sidml

@AlfredCP AlfredCP

Labels
automated workflows Automated Workflows core something about core development Development of new Functionalities enhancement New feature or request repo something about repo test Something about test
Projects
No open projects
New Functionalities
Done
Milestone
Partition Algorithm Implementation
Development

Successfully merging this pull request may close these issues.

Add EBV Partition Algorithm Benchmark workflow does not work! readFromStandardFile implementation
5 participants
@ZigRazor @codecov-commenter @AlfredCP @pavan-pan @sidml