Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce topological sort for graph #247

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Conversation

suncanghuai
Copy link
Contributor

  • implement topological sort based on dfs
  • add benchmark for topological sort
  • add basic test for topological sort
    @ZigRazor its my first submission for CXXGraph, may you review my commit and give some suggestions?

* implement topological sort based on dfs
* add benchmark for topological sort
* add basic test for topological sort
@github-actions github-actions bot added core something about core test Something about test labels Nov 1, 2022
@ghost
Copy link

ghost commented Nov 1, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@ZigRazor ZigRazor self-requested a review November 3, 2022 09:36
@ZigRazor ZigRazor self-assigned this Nov 3, 2022
@ZigRazor ZigRazor added this to the Algorithm Implementation milestone Nov 3, 2022
This was linked to issues Nov 3, 2022
Copy link
Owner

@ZigRazor ZigRazor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD ONE! Thank you for your submission

@ZigRazor ZigRazor merged commit be05a46 into ZigRazor:master Nov 3, 2022
ZigRazor added a commit that referenced this pull request Mar 21, 2023
* introduce topological sort for graph (#247)

* implement topological sort based on dfs
* add benchmark for topological sort
* add basic test for topological sort

Co-authored-by: suncanghuai <suncanghuai@gmail.com>

* Fix typo in link specification (#248)

This PR removes an additional space character between link text and link URL, which caused faulty formatting of the README.md file.

* introduce WeightBalancedLibra algorithm(vertex-cut graph partition) (#249)

* implement WeightBalancedLibra algorithm based on paper pseudocode
* add weight-related apis for class CoordinatedPartitionState
* adjust set operations of class CoordinatedRecord
* append a testcase in PartitionTest.cpp for WB-Libra

Co-authored-by: suncanghuai <suncanghuai@hesaitech.com>

* Update README.md

* Update README.md

* Install the CodeSee workflow. Learn more at https://docs.codesee.io (#250)

Co-authored-by: codesee-maps[bot] <86324825+codesee-maps[bot]@users.noreply.github.com>

* * implement multi-thread bfs (#252)

* add testcases for multi-thread bfs(in BFSTest.cpp)
* add benchmark for multi-thread bfs(in BFS_BM.cpp)

Co-authored-by: suncanghuai <suncanghuai@gmail.com>

* Update Readme Roadmap

* Implement best first search (#254)

* first implementation and tests

* add docs and minor changes

* minor change

* minor change

* Update README.md

* Update README.md

* Include best first search test (#258)

* Update README for best first search algorithm (#257)

* Update README for best first search algorithm

* minor change

* minor change

* minor review changes

* Implement kahn's algorithm for topological sorting (#259)

* Improved return type for Kosaraju's algoritm + tests (#260)

* custom return type for kosaraju()

* Tests for Kosaraju's algorithm

* fixed minor issues

* fixed merge issue

* Update Road Map

* Update README.md

* Reworked Cmake

Signed-off-by: GitHub <noreply@github.com>

* Add partition Example ( HDRF )

Signed-off-by: GitHub <noreply@github.com>

* Corrected Partition Class
Fix #263

Signed-off-by: GitHub <noreply@github.com>

* Update Readme for Roadmap

Signed-off-by: GitHub <noreply@github.com>

* Corrected Cmake for old Example

Signed-off-by: GitHub <noreply@github.com>

* Update cmake.yml

* Update benchmark_pr.yml

* Update benchmark.yml

* Update Code_Coverage.yml

* Correction for Graph.hpp

Signed-off-by: GitHub <noreply@github.com>

* Update Code_Coverage.yml

Parallel compilation

* Update benchmark.yml

parallel compilation

* Update benchmark_pr.yml

parallel compilation

* Update cmake.yml

parallel compilation

* Update codeql-analysis.yml

remove useless steps:
- manually installed google test and benchmark

* Create .github/workflows/super-linter.yml

Added Super-Linter

* Update super-linter.yml

* Create .clang-format

* Reformatted Files
with clang-format with syle "Google"

Signed-off-by: GitHub <noreply@github.com>

* Delete super-linter.yml

* Create .github/workflows/codeql.yml

* Delete codeql-analysis.yml

* Update README.md

* Create .github/workflows/codacy.yml

* Create .github/workflows/snyk-security.yml

* Update snyk-security.yml

* Delete snyk-security.yml

---------

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: ARockHammer <37604654+SunCangHuai@users.noreply.github.com>
Co-authored-by: suncanghuai <suncanghuai@gmail.com>
Co-authored-by: David Chocholatý <chocholaty.david@protonmail.com>
Co-authored-by: suncanghuai <suncanghuai@hesaitech.com>
Co-authored-by: codesee-maps[bot] <86324825+codesee-maps[bot]@users.noreply.github.com>
Co-authored-by: Pradeep Krishnamurthy <pradkrish84@gmail.com>
Co-authored-by: David Sapienza <david.sapienza@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core something about core test Something about test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Topological Sort for Graph Implement Graph Topological Sort
2 participants