Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for best first search algorithm #257

Merged
merged 4 commits into from
Dec 28, 2022

Conversation

pradkrish
Copy link
Contributor

@pradkrish pradkrish commented Dec 24, 2022

Closes #255

@github-actions github-actions bot added the repo something about repo label Dec 24, 2022
@ghost
Copy link

ghost commented Dec 24, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2022

Codecov Report

Merging #257 (40a4ae2) into master (b204beb) will increase coverage by 0.13%.
The diff coverage is n/a.

❗ Current head 40a4ae2 differs from pull request most recent head 9379fa5. Consider uploading reports for the commit 9379fa5 to get more accurate results

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   96.81%   96.94%   +0.13%     
==========================================
  Files          48       48              
  Lines        5895     5895              
==========================================
+ Hits         5707     5715       +8     
+ Misses        188      180       -8     
Flag Coverage Δ
unittests 96.94% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/Partitioning/GreedyVertexCut.hpp 84.69% <0.00%> (-2.05%) ⬇️
include/Partitioning/WeightBalancedLibra.hpp 77.77% <0.00%> (-1.39%) ⬇️
include/Partitioning/EBV.hpp 92.53% <0.00%> (+4.47%) ⬆️
include/Partitioning/HDRF.hpp 81.31% <0.00%> (+5.49%) ⬆️
include/Partitioning/EdgeBalancedVertexCut.hpp 84.31% <0.00%> (+5.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Owner

@ZigRazor ZigRazor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please insert the algorithm in the right section.
Actually is in the section of partition algorithm, and is wrong.
Please also insert an entry in the table of contents.

Copy link
Owner

@ZigRazor ZigRazor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply the change in the comment

@ZigRazor ZigRazor merged commit bcce7bf into ZigRazor:master Dec 28, 2022
ZigRazor added a commit that referenced this pull request Mar 21, 2023
* introduce topological sort for graph (#247)

* implement topological sort based on dfs
* add benchmark for topological sort
* add basic test for topological sort

Co-authored-by: suncanghuai <suncanghuai@gmail.com>

* Fix typo in link specification (#248)

This PR removes an additional space character between link text and link URL, which caused faulty formatting of the README.md file.

* introduce WeightBalancedLibra algorithm(vertex-cut graph partition) (#249)

* implement WeightBalancedLibra algorithm based on paper pseudocode
* add weight-related apis for class CoordinatedPartitionState
* adjust set operations of class CoordinatedRecord
* append a testcase in PartitionTest.cpp for WB-Libra

Co-authored-by: suncanghuai <suncanghuai@hesaitech.com>

* Update README.md

* Update README.md

* Install the CodeSee workflow. Learn more at https://docs.codesee.io (#250)

Co-authored-by: codesee-maps[bot] <86324825+codesee-maps[bot]@users.noreply.github.com>

* * implement multi-thread bfs (#252)

* add testcases for multi-thread bfs(in BFSTest.cpp)
* add benchmark for multi-thread bfs(in BFS_BM.cpp)

Co-authored-by: suncanghuai <suncanghuai@gmail.com>

* Update Readme Roadmap

* Implement best first search (#254)

* first implementation and tests

* add docs and minor changes

* minor change

* minor change

* Update README.md

* Update README.md

* Include best first search test (#258)

* Update README for best first search algorithm (#257)

* Update README for best first search algorithm

* minor change

* minor change

* minor review changes

* Implement kahn's algorithm for topological sorting (#259)

* Improved return type for Kosaraju's algoritm + tests (#260)

* custom return type for kosaraju()

* Tests for Kosaraju's algorithm

* fixed minor issues

* fixed merge issue

* Update Road Map

* Update README.md

* Reworked Cmake

Signed-off-by: GitHub <noreply@github.com>

* Add partition Example ( HDRF )

Signed-off-by: GitHub <noreply@github.com>

* Corrected Partition Class
Fix #263

Signed-off-by: GitHub <noreply@github.com>

* Update Readme for Roadmap

Signed-off-by: GitHub <noreply@github.com>

* Corrected Cmake for old Example

Signed-off-by: GitHub <noreply@github.com>

* Update cmake.yml

* Update benchmark_pr.yml

* Update benchmark.yml

* Update Code_Coverage.yml

* Correction for Graph.hpp

Signed-off-by: GitHub <noreply@github.com>

* Update Code_Coverage.yml

Parallel compilation

* Update benchmark.yml

parallel compilation

* Update benchmark_pr.yml

parallel compilation

* Update cmake.yml

parallel compilation

* Update codeql-analysis.yml

remove useless steps:
- manually installed google test and benchmark

* Create .github/workflows/super-linter.yml

Added Super-Linter

* Update super-linter.yml

* Create .clang-format

* Reformatted Files
with clang-format with syle "Google"

Signed-off-by: GitHub <noreply@github.com>

* Delete super-linter.yml

* Create .github/workflows/codeql.yml

* Delete codeql-analysis.yml

* Update README.md

* Create .github/workflows/codacy.yml

* Create .github/workflows/snyk-security.yml

* Update snyk-security.yml

* Delete snyk-security.yml

---------

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: ARockHammer <37604654+SunCangHuai@users.noreply.github.com>
Co-authored-by: suncanghuai <suncanghuai@gmail.com>
Co-authored-by: David Chocholatý <chocholaty.david@protonmail.com>
Co-authored-by: suncanghuai <suncanghuai@hesaitech.com>
Co-authored-by: codesee-maps[bot] <86324825+codesee-maps[bot]@users.noreply.github.com>
Co-authored-by: Pradeep Krishnamurthy <pradkrish84@gmail.com>
Co-authored-by: David Sapienza <david.sapienza@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repo something about repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Best First Algorithm Documentation on README
3 participants